Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 7794024: Merge 98772 - Fix regression in printing page settings CSS properties. (Closed)

Created:
9 years, 3 months ago by vandebo (ex-Chrome)
Modified:
9 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Merge 98772 - Fix regression in printing page settings CSS properties. PrintWebViewHelper::GetPageSizeAndMarginsInPoints may update PrintMsg_Print_Params, so we must call UpdatePrintParams after that. BUG=94294 TEST=Described in bug - print a page with page margin CSS. Review URL: http://codereview.chromium.org/7794010 TBR=vandebo@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98832

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/renderer/print_web_view_helper.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
vandebo (ex-Chrome)
9 years, 3 months ago (2011-08-30 17:18:18 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698