Issue 7794010: Fix regression in printing page settings CSS properties.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7794010: Fix regression in printing page settings CSS properties. (Closed)

Created:
9 years, 3 months ago by vandebo (ex-Chrome)

Modified:
9 years, 3 months ago

Reviewers:
Lei Zhang, commit-bot: I haz the power

CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix regression in printing page settings CSS properties. PrintWebViewHelper::GetPageSizeAndMarginsInPoints may update PrintMsg_Print_Params, so we must call UpdatePrintParams after that. BUG=94294 TEST=Described in bug - print a page with page margin CSS. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98772

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/renderer/print_web_view_helper.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Change committed as 98772

Expand Messages | Collapse Messages