Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: chrome/renderer/print_web_view_helper.cc

Issue 7794010: Fix regression in printing page settings CSS properties. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/print_web_view_helper.cc
diff --git a/chrome/renderer/print_web_view_helper.cc b/chrome/renderer/print_web_view_helper.cc
index 18a7eb3c278618c2c37e8aa32e96c53cb96d818f..f88ec96130a740caba4104a8a478dee3dc463632 100644
--- a/chrome/renderer/print_web_view_helper.cc
+++ b/chrome/renderer/print_web_view_helper.cc
@@ -987,7 +987,6 @@ void PrintWebViewHelper::UpdatePrintableSizeInPrintParameters(
PrepareFrameAndViewForPrint* prepare,
PrintMsg_Print_Params* params) {
PageSizeMargins page_layout_in_points;
- prepare->UpdatePrintParams(*params);
PrintWebViewHelper::GetPageSizeAndMarginsInPoints(frame, 0, *params,
&page_layout_in_points);
int dpi = GetDPI(params);
@@ -1018,6 +1017,8 @@ void PrintWebViewHelper::UpdatePrintableSizeInPrintParameters(
page_layout_in_points.margin_top, printing::kPointsPerInch, dpi));
params->margin_left = static_cast<int>(ConvertUnitDouble(
page_layout_in_points.margin_left, printing::kPointsPerInch, dpi));
+
+ prepare->UpdatePrintParams(*params);
}
bool PrintWebViewHelper::InitPrintSettings(WebKit::WebFrame* frame,
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698