Moved the handling of the initial passphrase into SyncSetupFlow.

Moved the handling of the initial passphrase into SyncSetupFlow.

This makes the passphrase handling more uniform across platforms, which should
result in fewer bugs on non-desktop-ui platforms and also pave the way for
OAuth integration.

Also updated the "autostart sync" code to enable it to be used on non-cros platforms.

BUG=95002, 91443, 82221
TEST=run through signin/setup test cases

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99504

[Andrew T Wilson (Slow), 2011-09-02 17:54:44]

Please take a look - there's a problem with the integration tests that I am
looking at, but it won't impact the rest of the CL (just integration test
setup).

[Rick Campbell, 2011-09-02 18:31:29]

LGTM with some administrivia

http://codereview.chromium.org/7792093/diff/4012/chrome/browser/sync/profile_...
File chrome/browser/sync/profile_sync_service.cc (right):

http://codereview.chromium.org/7792093/diff/4012/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_service.cc:648: // TODO(sync): This call to
ShowConfigure() should go away in favor
Bug number?

http://codereview.chromium.org/7792093/diff/4012/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_service.cc:823: if
(!cached_passphrases_.gaia_passphrase.empty()) {
Submit a bug to follow-up on the logic here?  We may want/need checks to ensure
that only one of these is set, or we may want to avoid trying the Gaia
passphrase at all if the explicit is set.

http://codereview.chromium.org/7792093/diff/4012/chrome/browser/sync/sync_set...
File chrome/browser/sync/sync_setup_flow.cc (right):

http://codereview.chromium.org/7792093/diff/4012/chrome/browser/sync/sync_set...
chrome/browser/sync/sync_setup_flow.cc:418: // TODO(atwilson): Remove
ShowPassphraseEntry (use ShowConfigure()).
Bug number?

[Andrew T Wilson (Slow), 2011-09-02 21:40:46]

http://codereview.chromium.org/7792093/diff/4012/chrome/browser/sync/profile_...
File chrome/browser/sync/profile_sync_service.cc (right):

http://codereview.chromium.org/7792093/diff/4012/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_service.cc:648: // TODO(sync): This call to
ShowConfigure() should go away in favor
On 2011/09/02 18:31:29, Rick Campbell wrote:
> Bug number?

Done.

http://codereview.chromium.org/7792093/diff/4012/chrome/browser/sync/profile_...
chrome/browser/sync/profile_sync_service.cc:823: if
(!cached_passphrases_.gaia_passphrase.empty()) {
On 2011/09/02 18:31:29, Rick Campbell wrote:
> Submit a bug to follow-up on the logic here?  We may want/need checks to
ensure
> that only one of these is set, or we may want to avoid trying the Gaia
> passphrase at all if the explicit is set.

Done.

http://codereview.chromium.org/7792093/diff/4012/chrome/browser/sync/sync_set...
File chrome/browser/sync/sync_setup_flow.cc (right):

http://codereview.chromium.org/7792093/diff/4012/chrome/browser/sync/sync_set...
chrome/browser/sync/sync_setup_flow.cc:418: // TODO(atwilson): Remove
ShowPassphraseEntry (use ShowConfigure()).
On 2011/09/02 18:31:29, Rick Campbell wrote:
> Bug number?

Done.

[commit-bot: I haz the power, 2011-09-02 23:55:49]

Can't apply patch for file chrome/test/live_sync/passwords_helper.cc.
While running patch -p1 --forward --force;
A         chrome/test/live_sync
patching file chrome/test/live_sync/passwords_helper.cc
Hunk #1 FAILED at 104.
1 out of 1 hunk FAILED -- saving rejects to file
chrome/test/live_sync/passwords_helper.cc.rej

[commit-bot: I haz the power, 2011-09-03 00:41:47]

Presubmit check for 7792093-5012 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Warnings **
You might be calling functions intended only for testing from
production code. Please verify that the following usages are OK,
and email joi@chromium.org if you are seeing false positives:
  chrome/browser/sync/profile_sync_service_harness.cc:227
    service_->GetBackendMigratorForTest(); \
  chrome/browser/sync/profile_sync_service_harness.cc:432
    service()->GetBackendMigratorForTest()-> \
  chrome/browser/sync/profile_sync_service_harness.cc:433
    GetPendingMigrationTypesForTest(); \
  chrome/browser/sync/profile_sync_service_harness.cc:750
    service()->GetBackendMigratorForTest();

Presubmit checks took 1.9s to calculate.