Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6897)

Unified Diff: chrome/browser/sync/sync_setup_wizard_unittest.cc

Issue 7792093: Moved the handling of the initial passphrase into SyncSetupFlow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Painful merge after phajdan's last-minute huge bulk file move. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/sync_setup_flow.cc ('k') | chrome/browser/sync/test/live_sync/passwords_helper.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/sync_setup_wizard_unittest.cc
diff --git a/chrome/browser/sync/sync_setup_wizard_unittest.cc b/chrome/browser/sync/sync_setup_wizard_unittest.cc
index 4a8e867440c2923951509e44edaa13b2b7215ab3..107f8ebf9d4fb50fe155616a611dcce817d1be44 100644
--- a/chrome/browser/sync/sync_setup_wizard_unittest.cc
+++ b/chrome/browser/sync/sync_setup_wizard_unittest.cc
@@ -88,8 +88,7 @@ class ProfileSyncServiceForWizardTest : public ProfileSyncService {
}
virtual void SetPassphrase(const std::string& passphrase,
- bool is_explicit,
- bool is_creation) {
+ bool is_explicit) {
passphrase_ = passphrase;
}
@@ -235,10 +234,6 @@ class SyncSetupWizardTest : public BrowserWithTestWindowTest {
TEST_F(SyncSetupWizardTest, InitialStepLogin) {
SKIP_TEST_ON_MACOSX();
- DictionaryValue dialog_args;
- SyncSetupFlow::GetArgsForGaiaLogin(service_, &dialog_args);
- std::string json_start_args;
- base::JSONWriter::Write(&dialog_args, false, &json_start_args);
ListValue credentials;
std::string auth = "{\"user\":\"";
auth += std::string(kTestUser) + "\",\"pass\":\"";
@@ -255,7 +250,6 @@ TEST_F(SyncSetupWizardTest, InitialStepLogin) {
EXPECT_TRUE(wizard_->IsVisible());
EXPECT_EQ(SyncSetupWizard::GAIA_LOGIN, flow_->current_state_);
EXPECT_EQ(SyncSetupWizard::DONE, flow_->end_state_);
- EXPECT_EQ(json_start_args, flow_->dialog_start_args_);
// Simulate the user submitting credentials.
handler_.HandleSubmitAuth(&credentials);
@@ -273,7 +267,7 @@ TEST_F(SyncSetupWizardTest, InitialStepLogin) {
wizard_->Step(SyncSetupWizard::GAIA_LOGIN);
EXPECT_TRUE(wizard_->IsVisible());
EXPECT_EQ(SyncSetupWizard::GAIA_LOGIN, flow_->current_state_);
- dialog_args.Clear();
+ DictionaryValue dialog_args;
SyncSetupFlow::GetArgsForGaiaLogin(service_, &dialog_args);
EXPECT_EQ(4U, dialog_args.size());
std::string actual_user;
« no previous file with comments | « chrome/browser/sync/sync_setup_flow.cc ('k') | chrome/browser/sync/test/live_sync/passwords_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698