Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 7792078: Preload D3DX DLLs before ANGLE is loaded. (Closed)

Created:
9 years, 3 months ago by apatrick_chromium
Modified:
9 years, 3 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, apatrick_chromium
Visibility:
Public.

Description

Preload D3DX DLLs before ANGLE is loaded. This is in case they are not in the DLL search path. It tries the default search path first in case D3DX is installed in the regular place. If that fails then it uses an absolute path to where Chrome installs them. I moved the call to SetErrorMode to be before ANGLE is loaded. Without this, a failing call to LoadLibrary would result in the display of a dialog box. This is dependent on http://codereview.chromium.org/7831021. BUG=69610 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99892

Patch Set 1 : '' #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M content/gpu/gpu_main.cc View 2 chunks +13 lines, -13 lines 0 comments Download
M ui/gfx/gl/gl_implementation_win.cc View 1 3 chunks +32 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
apatrick_chromium
9 years, 3 months ago (2011-09-01 22:47:55 UTC) #1
apatrick_chromium
Updated to reflect AtExitManager changes. The try results are the same as for the referenced ...
9 years, 3 months ago (2011-09-02 18:00:30 UTC) #2
darin (slow to review)
LGTM
9 years, 3 months ago (2011-09-04 15:43:37 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-07 01:42:48 UTC) #4
Change committed as 99892

Powered by Google App Engine
This is Rietveld 408576698