Issue 7831021: Support for registering arbitrary Tasks with AtExitManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7831021: Support for registering arbitrary Tasks with AtExitManager. (Closed)

Created:
9 years, 3 months ago by apatrick_chromium

Modified:
9 years, 3 months ago

Reviewers:
darin (slow to review), commit-bot: I haz the power

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Support for registering arbitrary Tasks with AtExitManager. Previously it was limitted to functions taling a single void* argument. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99856

Patch Set 1 : '' #

Total comments: 1

Patch Set 2 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -15 lines)			Patch
M	base/at_exit.h	View	1	3 chunks	+6 lines, -9 lines	0 comments	Download
M	base/at_exit.cc	View	1	3 chunks	+11 lines, -6 lines	0 comments	Download
M	base/at_exit_unittest.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

Looks good, but... http://codereview.chromium.org/7831021/diff/1005/base/at_exit.h File base/at_exit.h (right): http://codereview.chromium.org/7831021/diff/1005/base/at_exit.h#newcode50 base/at_exit.h:50: static void RegisterTask(Task* task); how about ...

9 years, 3 months ago (2011-09-01 23:35:44 UTC) #2

apatrick_chromium

PTAL. Try results look okay but they aren't showing up on codereview. http://build.chromium.org/p/tryserver.chromium/builders/linux/builds/46905 http://build.chromium.org/p/tryserver.chromium/builders/win/builds/52781 http://build.chromium.org/p/tryserver.chromium/builders/mac/builds/46889

9 years, 3 months ago (2011-09-02 17:58:32 UTC) #3

Change committed as 99856

Expand Messages | Collapse Messages