Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 7792077: Fix a benign off-by-one error of kNumSerials in IsBlacklisted. (Closed)

Created:
9 years, 3 months ago by wtc
Modified:
9 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Fix a benign off-by-one error of kNumSerials in IsBlacklisted. Remove duplicate certificate data in google_diginotar.pem and diginotar_public_ca_2025.pem. R=agl@chromium.org BUG=94673 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99494

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -68 lines) Patch
M net/base/x509_certificate.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/data/ssl/certificates/diginotar_public_ca_2025.pem View 1 1 chunk +0 lines, -35 lines 0 comments Download
M net/data/ssl/certificates/google_diginotar.pem View 1 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wtc
http://codereview.chromium.org/7792077/diff/1/net/base/x509_certificate.cc File net/base/x509_certificate.cc (right): http://codereview.chromium.org/7792077/diff/1/net/base/x509_certificate.cc#newcode644 net/base/x509_certificate.cc:644: static const unsigned kNumSerials = 256; I verified that ...
9 years, 3 months ago (2011-09-01 21:15:19 UTC) #1
agl
LGTM, thanks.
9 years, 3 months ago (2011-09-01 21:18:21 UTC) #2
wtc
rvargas: agl is on vacation today. Could you please review Patch Set 2? I discovered ...
9 years, 3 months ago (2011-09-02 18:32:02 UTC) #3
rvargas (doing something else)
LGTM
9 years, 3 months ago (2011-09-02 19:03:36 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-09-03 01:00:25 UTC) #5
Change committed as 99494

Powered by Google App Engine
This is Rietveld 408576698