WindowOpenDisposition should not be exposed in base and ui modules. (mac)

chrome/browser/ui/cocoa/event_utils.h

Index: chrome/browser/ui/cocoa/event_utils.h
diff --git a/chrome/browser/ui/cocoa/event_utils.h b/chrome/browser/ui/cocoa/event_utils.h
index a8f24f8f23b8955949bdbfe4388a2fedec7aad73..8c1e85aa4305d30650412d5b9fc73fc098aaf86c 100644
--- a/chrome/browser/ui/cocoa/event_utils.h
+++ b/chrome/browser/ui/cocoa/event_utils.h
@@ -12,6 +12,16 @@
 
 namespace event_utils {
 
+// Retrieves a bitsum of ui::EventFlags represented by |event|,
+int EventFlagsFromNSEvent(NSEvent* event);
+
+// Retrieves a bitsum of ui::EventFlags represented by |event|,
+// but instead use the modifier flags given by |flags|,

[Avi (use Gerrit), 2011/08/30 20:11:17]

s/|flags|/|modifiers|/ ?

[shinyak (Google), 2011/08/31 06:09:23]

Done.

+// which is the same format as |-NSEvent modifierFlags|. This allows
+// substitution of the modifiers without having to create a new event from
+// scratch.
+int EventFlagsFromNSEventWithModifiers(NSEvent* event, NSUInteger modifiers);
+
 // Retrieves the WindowOpenDisposition used to open a link from a user gesture
 // represented by |event|. For example, a Cmd+Click would mean open the
 // associated link in a background tab.