WindowOpenDisposition should not be exposed in base and ui modules. (mac)

chrome/browser/ui/cocoa/event_utils.h

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_EVENT_UTILS_H_
 #define CHROME_BROWSER_UI_COCOA_EVENT_UTILS_H_
 #pragma once
 
 #import <Cocoa/Cocoa.h>
 
 #include "webkit/glue/window_open_disposition.h"
 
 namespace event_utils {
 
+// Retrieves a bitsum of ui::EventFlags represented by |event|,
+int EventFlagsFromNSEvent(NSEvent* event);
+
+// Retrieves a bitsum of ui::EventFlags represented by |event|,
+// but instead use the modifier flags given by |flags|,

[Avi (use Gerrit), 2011/08/30 20:11:17]

s/|flags|/|modifiers|/ ?

[shinyak (Google), 2011/08/31 06:09:23]

Done.

+// which is the same format as |-NSEvent modifierFlags|. This allows
+// substitution of the modifiers without having to create a new event from
+// scratch.
+int EventFlagsFromNSEventWithModifiers(NSEvent* event, NSUInteger modifiers);
+
 // Retrieves the WindowOpenDisposition used to open a link from a user gesture
 // represented by |event|. For example, a Cmd+Click would mean open the
 // associated link in a background tab.
 WindowOpenDisposition WindowOpenDispositionFromNSEvent(NSEvent* event);
 
 // Retrieves the WindowOpenDisposition used to open a link from a user gesture
 // represented by |event|, but instead use the modifier flags given by |flags|,
 // which is the same format as |-NSEvent modifierFlags|. This allows
 // substitution of the modifiers without having to create a new event from
 // scratch.
 WindowOpenDisposition WindowOpenDispositionFromNSEventWithFlags(
     NSEvent* event, NSUInteger flags);
 
 }  // namespace event_utils
 
 #endif  // CHROME_BROWSER_UI_COCOA_EVENT_UTILS_H_