WindowOpenDisposition should not be exposed in base and ui modules. (mac)

NOTE:
The last goal of this series of patches is to unexpose WindowOpenDisposition in ui and base modules.

This patch introduces the platform independent (key or mouse) events for mac. It provides a conversion function from mac event to the platform independent events.

After this patch is landed, I will upload the main patch of this series. It will remove the code where WindowOpenDisposition is exposed to ui/base level, and will introduce (context menu) handlers with platform independent event flags.

See also http://codereview.chromium.org/6893046/

BUG=93700
TEST=EventUtilsTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98936

[Ben Goodger (Google), 2011-08-30 20:07:41]

A mac savvy person should review this.

[Avi (use Gerrit), 2011-08-30 20:11:17]

With fixes, LGTM

http://codereview.chromium.org/7792048/diff/1/chrome/browser/ui/cocoa/event_u...
File chrome/browser/ui/cocoa/event_utils.h (right):

http://codereview.chromium.org/7792048/diff/1/chrome/browser/ui/cocoa/event_u...
chrome/browser/ui/cocoa/event_utils.h:19: // but instead use the modifier flags
given by |flags|,
s/|flags|/|modifiers|/ ?

http://codereview.chromium.org/7792048/diff/1/chrome/browser/ui/cocoa/event_u...
File chrome/browser/ui/cocoa/event_utils.mm (right):

http://codereview.chromium.org/7792048/diff/1/chrome/browser/ui/cocoa/event_u...
chrome/browser/ui/cocoa/event_utils.mm:11: namespace {
mark end of namespace with //  namespace, and within a namespace there is no
indent

[shinyak (Google), 2011-08-31 06:09:22]

http://codereview.chromium.org/7792048/diff/1/chrome/browser/ui/cocoa/event_u...
File chrome/browser/ui/cocoa/event_utils.h (right):

http://codereview.chromium.org/7792048/diff/1/chrome/browser/ui/cocoa/event_u...
chrome/browser/ui/cocoa/event_utils.h:19: // but instead use the modifier flags
given by |flags|,
On 2011/08/30 20:11:17, Avi wrote:
> s/|flags|/|modifiers|/ ?

Done.

http://codereview.chromium.org/7792048/diff/1/chrome/browser/ui/cocoa/event_u...
File chrome/browser/ui/cocoa/event_utils.mm (right):

http://codereview.chromium.org/7792048/diff/1/chrome/browser/ui/cocoa/event_u...
chrome/browser/ui/cocoa/event_utils.mm:11: namespace {
On 2011/08/30 20:11:17, Avi wrote:
> mark end of namespace with //  namespace, and within a namespace there is no
> indent

Done.

[commit-bot: I haz the power, 2011-08-31 08:02:29]

Change committed as 98936