Issue 7792014: Fixes crash in Browser::Observe. We can end up here during creation of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7792014: Fixes crash in Browser::Observe. We can end up here during creation of (Closed)

Created:
9 years, 3 months ago by sky

Modified:
9 years, 3 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fixes crash in Browser::Observe. We can end up here during creation of the window, at which point window_ is NULL. This can happen because SHAppBarMessage runs a nested message loop pumping events. I suspect the right fix is to not invoke SHAppBarMessage, but that'll have to be done separately. BUG=94614 TEST=none R=ben@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98839

Patch Set 1 #

Patch Set 2 : Comment tweaks #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	chrome/browser/ui/browser.cc	View	1	1 chunk	+3 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Ben Goodger (Google)

9 years, 3 months ago (2011-08-30 17:19:49 UTC) #2

LGTM

http://codereview.chromium.org/7792014/diff/2001/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/7792014/diff/2001/chrome/browser/ui/browser.cc...
chrome/browser/ui/browser.cc:3931: // NULL.
Add the rest of your CL comment here about SHAppBarMessage.

Expand Messages | Collapse Messages