chrome/browser/ui/browser.cc - Issue 7792014: Fixes crash in Browser::Observe. We can end up here during creation of

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 7792014: Fixes crash in Browser::Observe. We can end up here during creation of (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comment tweaks Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 66990b19eabdc543c08b2798849d14e905f76b8a..06016f038c040bb9de5eb0b552f9b112cfce15c6 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -3927,7 +3927,9 @@ void Browser::Observe(int type,

case chrome::NOTIFICATION_EXTENSION_UNINSTALLED:

case chrome::NOTIFICATION_EXTENSION_LOADED:

- if (window()->GetLocationBar())

+ // We can end up here when creating the window, at which point window_ is

+ // NULL.

Ben Goodger (Google) 2011/08/30 17:19:49 Add the rest of your CL comment here about SHAppBa

+ if (window() && window()->GetLocationBar())

window()->GetLocationBar()->UpdatePageActions();

break;

« no previous file with comments | « no previous file | no next file » | no next file with comments »