Issue 7787007: Key external array map transitions on ElementsKind instead of ExternalArrayType

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7787007: Key external array map transitions on ElementsKind instead of ExternalArrayType (Closed)

Created:
9 years, 3 months ago by danno

Modified:
9 years, 3 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Description

Key external array map transitions on ElementsKind instead of ExternalArrayType R=jkummrow@chromium.org BUG=none TEST=none Committed: http://code.google.com/p/v8/source/detail?r=9214

Patch Set 1 #

Patch Set 2 : Fix whitespace #

Total comments: 3

Patch Set 3 : merge with latest #

Patch Set 4 : review feedback #

Patch Set 5 : review feedback #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -100 lines)			Patch
M	src/api.cc	View	1 2	3 chunks	+39 lines, -2 lines	0 comments	Download
M	src/bootstrapper.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/factory.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/factory.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/objects.h	View	1 2	5 chunks	+13 lines, -13 lines	0 comments	Download
M	src/objects.cc	View	1 2 3 4	11 chunks	+27 lines, -63 lines	0 comments	Download
M	src/objects-inl.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/property.h	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	src/property.cc	View	1 2 3	2 chunks	+3 lines, -3 lines	0 comments	Download
M	src/runtime.cc	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	src/v8globals.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

9 years, 3 months ago (2011-09-09 07:55:53 UTC) #2

LGTM

http://codereview.chromium.org/7787007/diff/2001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7787007/diff/2001/src/objects.cc#newcode1439
src/objects.cc:1439: // External array transitions are stored in the descriptor
for property "",
s/External array/Elements/

http://codereview.chromium.org/7787007/diff/2001/src/objects.cc#newcode2040
src/objects.cc:2040: // non-matching external array transition.
s/external array/elements/

http://codereview.chromium.org/7787007/diff/2001/src/property.cc
File src/property.cc (right):

http://codereview.chromium.org/7787007/diff/2001/src/property.cc#newcode56
src/property.cc:56: PrintF(out, " -type = external array transition\n");
s/external array/elements/

Expand Messages | Collapse Messages