Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: src/objects-inl.h

Issue 7787007: Key external array map transitions on ElementsKind instead of ExternalArrayType (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: review feedback Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/property.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1982 matching lines...) Expand 10 before | Expand all | Expand 10 after
1993 1993
1994 1994
1995 bool DescriptorArray::IsProperty(int descriptor_number) { 1995 bool DescriptorArray::IsProperty(int descriptor_number) {
1996 return GetType(descriptor_number) < FIRST_PHANTOM_PROPERTY_TYPE; 1996 return GetType(descriptor_number) < FIRST_PHANTOM_PROPERTY_TYPE;
1997 } 1997 }
1998 1998
1999 1999
2000 bool DescriptorArray::IsTransition(int descriptor_number) { 2000 bool DescriptorArray::IsTransition(int descriptor_number) {
2001 PropertyType t = GetType(descriptor_number); 2001 PropertyType t = GetType(descriptor_number);
2002 return t == MAP_TRANSITION || t == CONSTANT_TRANSITION || 2002 return t == MAP_TRANSITION || t == CONSTANT_TRANSITION ||
2003 t == EXTERNAL_ARRAY_TRANSITION; 2003 t == ELEMENTS_TRANSITION;
2004 } 2004 }
2005 2005
2006 2006
2007 bool DescriptorArray::IsNullDescriptor(int descriptor_number) { 2007 bool DescriptorArray::IsNullDescriptor(int descriptor_number) {
2008 return GetType(descriptor_number) == NULL_DESCRIPTOR; 2008 return GetType(descriptor_number) == NULL_DESCRIPTOR;
2009 } 2009 }
2010 2010
2011 2011
2012 bool DescriptorArray::IsDontEnum(int descriptor_number) { 2012 bool DescriptorArray::IsDontEnum(int descriptor_number) {
2013 return PropertyDetails(GetDetails(descriptor_number)).IsDontEnum(); 2013 return PropertyDetails(GetDetails(descriptor_number)).IsDontEnum();
(...skipping 2671 matching lines...) Expand 10 before | Expand all | Expand 10 after
4685 #undef WRITE_INT_FIELD 4685 #undef WRITE_INT_FIELD
4686 #undef READ_SHORT_FIELD 4686 #undef READ_SHORT_FIELD
4687 #undef WRITE_SHORT_FIELD 4687 #undef WRITE_SHORT_FIELD
4688 #undef READ_BYTE_FIELD 4688 #undef READ_BYTE_FIELD
4689 #undef WRITE_BYTE_FIELD 4689 #undef WRITE_BYTE_FIELD
4690 4690
4691 4691
4692 } } // namespace v8::internal 4692 } } // namespace v8::internal
4693 4693
4694 #endif // V8_OBJECTS_INL_H_ 4694 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/property.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698