Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 7779033: Fix a few clang warnings (which -Werror treats as errors) (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow
Modified:
9 years, 3 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Fix a few clang warnings (which -Werror treats as errors) Committed: http://code.google.com/p/v8/source/detail?r=9141

Patch Set 1 #

Total comments: 2

Patch Set 2 : there, that's better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -13 lines) Patch
M src/conversions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/jsregexp.h View 1 chunk +1 line, -1 line 0 comments Download
M src/jsregexp.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M test/cctest/test-api.cc View 2 chunks +11 lines, -4 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jakob Kummerow
PTAL. No intended functionality changes.
9 years, 3 months ago (2011-09-05 10:56:19 UTC) #1
Sven Panne
http://codereview.chromium.org/7779033/diff/1/test/cctest/test-compiler.cc File test/cctest/test-compiler.cc (right): http://codereview.chromium.org/7779033/diff/1/test/cctest/test-compiler.cc#newcode78 test/cctest/test-compiler.cc:78: printf("%u", static_cast<wint_t>(string[j])); This changes the output: Now we print ...
9 years, 3 months ago (2011-09-05 11:39:36 UTC) #2
Jakob Kummerow
wchar_t != wint_t :-) http://codereview.chromium.org/7779033/diff/1/test/cctest/test-compiler.cc File test/cctest/test-compiler.cc (right): http://codereview.chromium.org/7779033/diff/1/test/cctest/test-compiler.cc#newcode78 test/cctest/test-compiler.cc:78: printf("%u", static_cast<wint_t>(string[j])); On 2011/09/05 11:39:36, ...
9 years, 3 months ago (2011-09-05 15:05:45 UTC) #3
Sven Panne
9 years, 3 months ago (2011-09-06 06:58:09 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698