Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: src/conversions.h

Issue 7779033: Fix a few clang warnings (which -Werror treats as errors) (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: there, that's better Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 27 matching lines...) Expand all
38 // Maximum number of significant digits in decimal representation. 38 // Maximum number of significant digits in decimal representation.
39 // The longest possible double in decimal representation is 39 // The longest possible double in decimal representation is
40 // (2^53 - 1) * 2 ^ -1074 that is (2 ^ 53 - 1) * 5 ^ 1074 / 10 ^ 1074 40 // (2^53 - 1) * 2 ^ -1074 that is (2 ^ 53 - 1) * 5 ^ 1074 / 10 ^ 1074
41 // (768 digits). If we parse a number whose first digits are equal to a 41 // (768 digits). If we parse a number whose first digits are equal to a
42 // mean of 2 adjacent doubles (that could have up to 769 digits) the result 42 // mean of 2 adjacent doubles (that could have up to 769 digits) the result
43 // must be rounded to the bigger one unless the tail consists of zeros, so 43 // must be rounded to the bigger one unless the tail consists of zeros, so
44 // we don't need to preserve all the digits. 44 // we don't need to preserve all the digits.
45 const int kMaxSignificantDigits = 772; 45 const int kMaxSignificantDigits = 772;
46 46
47 47
48 static bool isDigit(int x, int radix) { 48 static inline bool isDigit(int x, int radix) {
49 return (x >= '0' && x <= '9' && x < '0' + radix) 49 return (x >= '0' && x <= '9' && x < '0' + radix)
50 || (radix > 10 && x >= 'a' && x < 'a' + radix - 10) 50 || (radix > 10 && x >= 'a' && x < 'a' + radix - 10)
51 || (radix > 10 && x >= 'A' && x < 'A' + radix - 10); 51 || (radix > 10 && x >= 'A' && x < 'A' + radix - 10);
52 } 52 }
53 53
54 54
55 static double SignedZero(bool negative) { 55 static inline double SignedZero(bool negative) {
56 return negative ? -0.0 : 0.0; 56 return negative ? -0.0 : 0.0;
57 } 57 }
58 58
59 59
60 // The fast double-to-(unsigned-)int conversion routine does not guarantee 60 // The fast double-to-(unsigned-)int conversion routine does not guarantee
61 // rounding towards zero. 61 // rounding towards zero.
62 // The result is unspecified if x is infinite or NaN, or if the rounded 62 // The result is unspecified if x is infinite or NaN, or if the rounded
63 // integer value is outside the range of type int. 63 // integer value is outside the range of type int.
64 static inline int FastD2I(double x) { 64 static inline int FastD2I(double x) {
65 // The static_cast convertion from double to int used to be slow, but 65 // The static_cast convertion from double to int used to be slow, but
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
137 // Additional number to string conversions for the number type. 137 // Additional number to string conversions for the number type.
138 // The caller is responsible for calling free on the returned pointer. 138 // The caller is responsible for calling free on the returned pointer.
139 char* DoubleToFixedCString(double value, int f); 139 char* DoubleToFixedCString(double value, int f);
140 char* DoubleToExponentialCString(double value, int f); 140 char* DoubleToExponentialCString(double value, int f);
141 char* DoubleToPrecisionCString(double value, int f); 141 char* DoubleToPrecisionCString(double value, int f);
142 char* DoubleToRadixCString(double value, int radix); 142 char* DoubleToRadixCString(double value, int radix);
143 143
144 } } // namespace v8::internal 144 } } // namespace v8::internal
145 145
146 #endif // V8_CONVERSIONS_H_ 146 #endif // V8_CONVERSIONS_H_
OLDNEW
« no previous file with comments | « no previous file | src/ia32/lithium-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698