Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 7779006: MIPS: Fix KeyedStoreStubCompiler::GenerateStoreFastDoubleElement() (Closed)

Created:
9 years, 3 months ago by Paul Lind
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Fix KeyedStoreStubCompiler::GenerateStoreFastDoubleElement() Test regress-91013.js (to ensure that the stored value was returned) passed on mips without this fix, since the input value (in value_reg, a0) also happens to be in mips return value register v0 at the time of call. But it is fragile to depend on that behavior, so an explicit move from a0 to v0 is warranted. This fix puts that move in the delay slot of the Ret(). Patch by Paul Lind. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9035

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/mips/stub-cache-mips.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Lind
Vyacheslav, this relates to an old commit of yours, r8781, and the mips port of ...
9 years, 3 months ago (2011-08-29 06:13:37 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 3 months ago (2011-08-29 08:58:20 UTC) #2
LGTM

Thanks Paul! I'll land.

Powered by Google App Engine
This is Rietveld 408576698