content/common/gpu/media/omx_video_decode_accelerator.h - Issue 7779001: Replace the use of an int32* with a proper struct for decoder configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/omx_video_decode_accelerator.h

Issue 7779001: Replace the use of an int32* with a proper struct for decoder configuration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/gpu_video_decode_accelerator.cc ('k') | content/common/gpu/media/omx_video_decode_accelerator.cc » ('j') | ppapi/cpp/dev/video_decoder_dev.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/omx_video_decode_accelerator.h

diff --git a/content/common/gpu/media/omx_video_decode_accelerator.h b/content/common/gpu/media/omx_video_decode_accelerator.h

index b74406854aeb7a107647772a6ebb612ad4a17c6d..924fb16232b919034201d1a0174f87fb92211e6d 100644

--- a/content/common/gpu/media/omx_video_decode_accelerator.h

+++ b/content/common/gpu/media/omx_video_decode_accelerator.h

@@ -42,7 +42,7 @@ class OmxVideoDecodeAccelerator : public media::VideoDecodeAccelerator {

OmxVideoDecodeAccelerator(media::VideoDecodeAccelerator::Client* client);

// media::VideoDecodeAccelerator implementation.

- bool Initialize(const std::vector<int32>& config) OVERRIDE;

+ bool Initialize(const Config& config) OVERRIDE;

void Decode(const media::BitstreamBuffer& bitstream_buffer) OVERRIDE;

virtual void AssignPictureBuffers(

const std::vector<media::PictureBuffer>& buffers) OVERRIDE;

@@ -82,9 +82,6 @@ class OmxVideoDecodeAccelerator : public media::VideoDecodeAccelerator {

};

typedef std::map<int32, OutputPicture> OutputPictureById;

- // Verify that |config| is compatible with this class and hardware.

- bool VerifyConfigs(const std::vector<int32>& configs);

MessageLoop* message_loop_;

OMX_HANDLETYPE component_handle_;