content/common/gpu/media/gpu_video_decode_accelerator.cc - Issue 7779001: Replace the use of an int32* with a proper struct for decoder configuration.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/media/gpu_video_decode_accelerator.cc

Issue 7779001: Replace the use of an int32* with a proper struct for decoder configuration. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebased Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/gpu/media/gpu_video_decode_accelerator.h ('k') | content/common/gpu/media/omx_video_decode_accelerator.h » ('j') | ppapi/cpp/dev/video_decoder_dev.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/gpu/media/gpu_video_decode_accelerator.cc

diff --git a/content/common/gpu/media/gpu_video_decode_accelerator.cc b/content/common/gpu/media/gpu_video_decode_accelerator.cc

index 54e909115ba52ab5001c228b769830cb7dcb03fd..657a8aa6841be9bfcac0620a5f54e1d35e04e0ac 100644

--- a/content/common/gpu/media/gpu_video_decode_accelerator.cc

+++ b/content/common/gpu/media/gpu_video_decode_accelerator.cc

@@ -104,7 +104,7 @@ void GpuVideoDecodeAccelerator::NotifyError(

}

void GpuVideoDecodeAccelerator::Initialize(

- const std::vector<int32>& configs,

+ const media::VideoDecodeAccelerator::Config& config,

IPC::Message* init_done_msg) {

DCHECK(!video_decode_accelerator_.get());

DCHECK(!init_done_msg_);

@@ -117,7 +117,7 @@ void GpuVideoDecodeAccelerator::Initialize(

gfx::GLSurfaceEGL::GetHardwareDisplay(),

stub_->scheduler()->decoder()->GetGLContext()->GetHandle());

video_decode_accelerator_ = omx_decoder;

- video_decode_accelerator_->Initialize(configs);

+ video_decode_accelerator_->Initialize(config);

#else

NOTIMPLEMENTED() << "HW video decode acceleration not available.";

NotifyError(media::VideoDecodeAccelerator::PLATFORM_FAILURE);