Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 7777006: Chrome Linux DRT nativeKeyCode helper #2 (Closed)

Created:
9 years, 3 months ago by Noel Gordon
Modified:
9 years, 3 months ago
CC:
tony, chromium-reviews
Visibility:
Public.

Description

Followup http://codereview.chromium.org/7740048: g_free() the keys map object (GdkKeymapKey*) returned by gdk_keymap_get_entries_for_keyval(). BUG=94211 TEST=webkit LayoutTests/plugins/keyboard-events.html Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98771

Patch Set 1 : Patch for trys and landing. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M ui/base/keycodes/keyboard_code_conversion_gtk.cc View 1 chunk +8 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Noel Gordon
9 years, 3 months ago (2011-08-29 09:18:07 UTC) #1
sky
LGTM
9 years, 3 months ago (2011-08-29 14:05:30 UTC) #2
commit-bot: I haz the power
9 years, 3 months ago (2011-08-30 04:14:44 UTC) #3
Change committed as 98771

Powered by Google App Engine
This is Rietveld 408576698