Chrome Linux DRT nativeKeyCode helper

Add a GTK support routine that returns a simulated nativeKeyCode for a given
windowKeyCode.  Simulated since there's no keyboard attached when testing in
webkit DRT, so DRT::eventSender.keyDown() must simulate keyboard events.

https://bugs.webkit.org/show_bug.cgi?id=66679

BUG=94211
TEST=webkit LayoutTests/plugins/keyboard-events.html

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98599

[tony, 2011-08-26 16:24:50]

LGTM, thanks!

http://codereview.chromium.org/7740048/diff/1/ui/base/keycodes/keyboard_code_...
File ui/base/keycodes/keyboard_code_conversion_gtk.cc (right):

http://codereview.chromium.org/7740048/diff/1/ui/base/keycodes/keyboard_code_...
ui/base/keycodes/keyboard_code_conversion_gtk.cc:638: // input |keycode|. 
Return the native keycode.
Nit: I would probably move this comment to the header.

[Noel Gordon, 2011-08-26 16:42:12]

http://codereview.chromium.org/7740048/diff/1/ui/base/keycodes/keyboard_code_...
File ui/base/keycodes/keyboard_code_conversion_gtk.cc (right):

http://codereview.chromium.org/7740048/diff/1/ui/base/keycodes/keyboard_code_...
ui/base/keycodes/keyboard_code_conversion_gtk.cc:638: // input |keycode|. 
Return the native keycode.
On 2011/08/26 16:24:51, tony wrote:
> Nit: I would probably move this comment to the header.

Done.

[Noel Gordon, 2011-08-26 16:54:10]

+ben,+sky: need OWNERS approval for ui/base.

[sky, 2011-08-26 17:06:39]

LGTM

http://codereview.chromium.org/7740048/diff/4001/ui/base/keycodes/keyboard_co...
File ui/base/keycodes/keyboard_code_conversion_gtk.cc (right):

http://codereview.chromium.org/7740048/diff/4001/ui/base/keycodes/keyboard_co...
ui/base/keycodes/keyboard_code_conversion_gtk.cc:637: int
GdkNativeKeyCodeForWindowsKeyCode(KeyboardCode keycode, bool shift) {
nit: make position match that in header.

[Noel Gordon, 2011-08-26 17:22:25]

On 2011/08/26 17:06:39, sky wrote:
> nit: make position match that in header.

Done, and for webkit_support.cc also.

[Noel Gordon, 2011-08-29 03:05:15]

linux_chromeos browser tests flaky with my change.  Needed a --clobber try to
turn it green.
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromeos/builds...

[commit-bot: I haz the power, 2011-08-29 04:26:42]

Try job failure for 7740048-10005 on win for steps "update_scripts, update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[Noel Gordon, 2011-08-29 04:32:21]

svn: Can't open file 'E:\b\depot_tools\tests\subversion_config\.svn\lock': The
disk structure is corrupted and unreadable.

[commit-bot: I haz the power, 2011-08-29 06:36:10]

Change committed as 98599