Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 7776010: Convert a bunch of ASSERTs to STATIC_ASSERTs (Closed)

Created:
9 years, 3 months ago by Jakob Kummerow
Modified:
9 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Convert a bunch of ASSERTs to STATIC_ASSERTs making our debug binaries ever so slightly faster Committed: http://code.google.com/p/v8/source/detail?r=9057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -62 lines) Patch
M src/arm/builtins-arm.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/ic-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/ia32/ic-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/scanner-base.h View 1 chunk +1 line, -1 line 0 comments Download
M src/stub-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/ic-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/macro-assembler-x64.cc View 8 chunks +10 lines, -10 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Jakob Kummerow
PTAL.
9 years, 3 months ago (2011-08-29 12:47:33 UTC) #1
Yang
9 years, 3 months ago (2011-08-29 13:01:46 UTC) #2
On 2011/08/29 12:47:33, Jakob wrote:
> PTAL.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698