Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Side by Side Diff: src/x64/ic-x64.cc

Issue 7776010: Convert a bunch of ASSERTs to STATIC_ASSERTs (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 360 matching lines...) Expand 10 before | Expand all | Expand 10 after
371 // map - used to hold the map of the key. 371 // map - used to hold the map of the key.
372 // hash - used to hold the hash of the key. 372 // hash - used to hold the hash of the key.
373 __ CmpObjectType(key, FIRST_NONSTRING_TYPE, map); 373 __ CmpObjectType(key, FIRST_NONSTRING_TYPE, map);
374 __ j(above_equal, not_symbol); 374 __ j(above_equal, not_symbol);
375 // Is the string an array index, with cached numeric value? 375 // Is the string an array index, with cached numeric value?
376 __ movl(hash, FieldOperand(key, String::kHashFieldOffset)); 376 __ movl(hash, FieldOperand(key, String::kHashFieldOffset));
377 __ testl(hash, Immediate(String::kContainsCachedArrayIndexMask)); 377 __ testl(hash, Immediate(String::kContainsCachedArrayIndexMask));
378 __ j(zero, index_string); // The value in hash is used at jump target. 378 __ j(zero, index_string); // The value in hash is used at jump target.
379 379
380 // Is the string a symbol? 380 // Is the string a symbol?
381 ASSERT(kSymbolTag != 0); 381 STATIC_ASSERT(kSymbolTag != 0);
382 __ testb(FieldOperand(map, Map::kInstanceTypeOffset), 382 __ testb(FieldOperand(map, Map::kInstanceTypeOffset),
383 Immediate(kIsSymbolMask)); 383 Immediate(kIsSymbolMask));
384 __ j(zero, not_symbol); 384 __ j(zero, not_symbol);
385 } 385 }
386 386
387 387
388 388
389 void KeyedLoadIC::GenerateGeneric(MacroAssembler* masm) { 389 void KeyedLoadIC::GenerateGeneric(MacroAssembler* masm) {
390 // ----------- S t a t e ------------- 390 // ----------- S t a t e -------------
391 // -- rax : key 391 // -- rax : key
(...skipping 1270 matching lines...) Expand 10 before | Expand all | Expand 10 after
1662 Condition cc = *jmp_address == Assembler::kJncShortOpcode 1662 Condition cc = *jmp_address == Assembler::kJncShortOpcode
1663 ? not_zero 1663 ? not_zero
1664 : zero; 1664 : zero;
1665 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc); 1665 *jmp_address = static_cast<byte>(Assembler::kJccShortPrefix | cc);
1666 } 1666 }
1667 1667
1668 1668
1669 } } // namespace v8::internal 1669 } } // namespace v8::internal
1670 1670
1671 #endif // V8_TARGET_ARCH_X64 1671 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/full-codegen-x64.cc ('k') | src/x64/macro-assembler-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698