Issue 7775001: Do not check against child_count() > 0, instead check if node is not empty().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7775001: Do not check against child_count() > 0, instead check if node is not empty(). (Closed)

Created:
9 years, 3 months ago by tfarina

Modified:
9 years, 3 months ago

Reviewers:
Greg Billock

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Do not check against child_count() > 0, instead check if node is not empty(). Use TreeNode::empty() accessor function for checking if node has children or if it isn't empty, instead of using child_count(). BUG=None TEST=None R=gbillock@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98639

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/intents/intents_model.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/ui/webui/options/intents_settings_handler.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

LGTM