chrome/browser/ui/intents/intents_model.cc - Issue 7775001: Do not check against child_count() > 0, instead check if node is not empty().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/intents/intents_model.cc

Issue 7775001: Do not check against child_count() > 0, instead check if node is not empty(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/intents/intents_model.cc

diff --git a/chrome/browser/ui/intents/intents_model.cc b/chrome/browser/ui/intents/intents_model.cc

index 919dbe36cc7a2ac34a477d7b1af8df480866efc3..4aa09112f47be05450f76aa9a024f3a0370523c3 100644

--- a/chrome/browser/ui/intents/intents_model.cc

+++ b/chrome/browser/ui/intents/intents_model.cc

@@ -95,7 +95,7 @@ void IntentsModel::GetIntentsTreeNodeDictionary(const IntentsTreeNode& node,

if (node.Type() == IntentsTreeNode::TYPE_ORIGIN) {

dict->SetString("site", node.GetTitle());

- dict->SetBoolean("hasChildren", node.child_count() > 0);

+ dict->SetBoolean("hasChildren", !node.empty());

return;

}

« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/intents_settings_handler.cc » ('j') | no next file with comments »