Issue 7769001: Adds support for point conversions to ui::Layer.

Issue 7769001: Adds support for point conversions to ui::Layer. (Closed)

Created:
9 years, 4 months ago by Ben Goodger (Google)

Modified:
9 years, 3 months ago

Reviewers:
sky, Paweł Hajdan Jr.

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Adds support for point conversions to ui::Layer. Also adds a skeleton for testing compositor API changes. BUG=none TEST=see unittest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98689

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Patch Set 4 : '' #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+430 lines, -0 lines)			Patch
M	ui/gfx/compositor/compositor.gyp	View	1 2 3	1 chunk	+27 lines, -0 lines	0 comments	Download
M	ui/gfx/compositor/layer.h	View	1 2 3	3 chunks	+16 lines, -0 lines	0 comments	Download
M	ui/gfx/compositor/layer.cc	View	1 2 3	4 chunks	+60 lines, -0 lines	0 comments	Download
A	ui/gfx/compositor/layer_unittest.cc	View	1 2	1 chunk	+162 lines, -0 lines	0 comments	Download
A	ui/gfx/compositor/run_all_unittests.cc	View	1 2 3	1 chunk	+9 lines, -0 lines	0 comments	Download
A	ui/gfx/compositor/test_compositor_host.h	View		1 chunk	+36 lines, -0 lines	0 comments	Download
A	ui/gfx/compositor/test_compositor_host_win.cc	View		1 chunk	+64 lines, -0 lines	0 comments	Download
A	ui/gfx/compositor/test_suite.h	View		1 chunk	+22 lines, -0 lines	0 comments	Download
A	ui/gfx/compositor/test_suite.cc	View		1 chunk	+32 lines, -0 lines	0 comments	Download
M	ui/ui.gyp	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

tfarina

http://codereview.chromium.org/7769001/diff/9001/ui/gfx/compositor/test_suite.cc File ui/gfx/compositor/test_suite.cc (right): http://codereview.chromium.org/7769001/diff/9001/ui/gfx/compositor/test_suite.cc#newcode7 ui/gfx/compositor/test_suite.cc:7: #include "base/file_path.h" could you remove this and the following ...

9 years, 4 months ago (2011-08-27 03:06:32 UTC) #2

sky

LGTM http://codereview.chromium.org/7769001/diff/9001/ui/gfx/compositor/run_all_unittests.cc File ui/gfx/compositor/run_all_unittests.cc (right): http://codereview.chromium.org/7769001/diff/9001/ui/gfx/compositor/run_all_unittests.cc#newcode1 ui/gfx/compositor/run_all_unittests.cc:1: // Copyright (c) 2010 The Chromium Authors. All ...

9 years, 3 months ago (2011-08-29 14:23:35 UTC) #3

Paweł Hajdan Jr.

Drive-by with a testing comment. http://codereview.chromium.org/7769001/diff/9001/ui/gfx/compositor/test_suite.cc File ui/gfx/compositor/test_suite.cc (right): http://codereview.chromium.org/7769001/diff/9001/ui/gfx/compositor/test_suite.cc#newcode14 ui/gfx/compositor/test_suite.cc:14: CompositorTestSuite::CompositorTestSuite(int argc, char** argv) ...

9 years, 3 months ago (2011-08-29 16:49:28 UTC) #4

Ben Goodger (Google)

Compositor is technically its own module similar to gfx. Perhaps this can live in ui/base, ...

9 years, 3 months ago (2011-08-29 17:04:54 UTC) #5

Ben Goodger (Google)

9 years, 3 months ago (2011-08-29 18:30:32 UTC) #6

Further investigation results:

Compositor is its own module and its own DLL. Anything that builds its own
DLL should be able to have its own test suite.

src/ui is more of an organizational thing than a module boundary. It is
meant to be a collection of modules that can be used for building app UI.

With that said, compositor should probably move to the toplevel rather than
being buried inside gfx. I can work on that.

-Ben

On Mon, Aug 29, 2011 at 10:04 AM, Ben Goodger (Google) <ben@chromium.org>wrote:

> Compositor is technically its own module similar to gfx.
>
> Perhaps this can live in ui/base, I'll investigate.
>
> -Ben
>
>
> On Mon, Aug 29, 2011 at 9:49 AM, <phajdan.jr@chromium.org> wrote:
>
>> Drive-by with a testing comment.
>>
>>
>> http://codereview.chromium.**org/7769001/diff/9001/ui/gfx/**
>>
compositor/test_suite.cc<http://codereview.chromium.org/7769001/diff/9001/ui/gfx/compositor/test_suite.cc>
>> File ui/gfx/compositor/test_suite.**cc (right):
>>
>> http://codereview.chromium.**org/7769001/diff/9001/ui/gfx/**
>>
compositor/test_suite.cc#**newcode14<http://codereview.chromium.org/7769001/diff/9001/ui/gfx/compositor/test_suite.cc#newcode14>
>> ui/gfx/compositor/test_suite.**cc:14:
>> CompositorTestSuite::**CompositorTestSuite(int argc, char** argv)
>> Why is this so deeply in ui/gfx/compositor? If we need a test suite for
>> ui/ I think it should be in ui/ for simplicity. Please avoid creating
>> too many test suites etc.
>>
>>
>>
http://codereview.chromium.**org/7769001/<http://codereview.chromium.org/7769...
>>
>
>

Expand Messages | Collapse Messages