Add logic to flip Nigori bit to instruct other clients to sync tabs.

Add logic to flip Nigori bit to instruct other clients to sync tabs.

For reference, see: http://codereview.chromium.org/7669073/

BUG=
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99317

[Andrew T Wilson (Slow), 2011-08-27 06:08:52]

Note the trybot errors on check_deps. I'm not sure why it's not legal to import
chrome/common from there, but LGTM once you've addressed the check_deps problem.

http://codereview.chromium.org/7767013/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/7767013/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:523: const char
kEnableSyncSessionsForOtherClients[]  =
"enable-sync-sessions-for-other-clients";
line >80 chars

[Yaron, 2011-08-29 18:41:54]

Fixed the deps issues and the nit

http://codereview.chromium.org/7767013/diff/1/chrome/common/chrome_switches.cc
File chrome/common/chrome_switches.cc (right):

http://codereview.chromium.org/7767013/diff/1/chrome/common/chrome_switches.c...
chrome/common/chrome_switches.cc:523: const char
kEnableSyncSessionsForOtherClients[]  =
"enable-sync-sessions-for-other-clients";
On 2011/08/27 06:08:52, Andrew T Wilson wrote:
> line >80 chars

Done.

[Yaron, 2011-08-29 18:56:53]

On 2011/08/29 18:41:54, Yaron wrote:
> Fixed the deps issues and the nit
> 
> http://codereview.chromium.org/7767013/diff/1/chrome/common/chrome_switches.cc
> File chrome/common/chrome_switches.cc (right):
> 
>
http://codereview.chromium.org/7767013/diff/1/chrome/common/chrome_switches.c...
> chrome/common/chrome_switches.cc:523: const char
> kEnableSyncSessionsForOtherClients[]  =
> "enable-sync-sessions-for-other-clients";
> On 2011/08/27 06:08:52, Andrew T Wilson wrote:
> > line >80 chars
> 
> Done.

Actually, this doesn't quite work as expected. Starting up a previously
configured client hits a CHECK because SignIn hasn't completed before the first
call to UpdateEnabledTypes (stack below). Should I add a conditional in
UpdateEnabledTypes to see that it's initialized and also call UpdateEnabledTypes
at the bottom of init? I was hoping there would be a single place where the user
has changed their preferred set of types and perform the modification there but
I don't see it. 


[16651:16685:242997249288:FATAL:sync_manager.cc(313)] Check failed:
initialized_.
Backtrace:
        base::debug::StackTrace::StackTrace() [0x7f099349a312]
        logging::LogMessage::~LogMessage() [0x7f0993421886]
        sync_api::SyncManager::SyncInternal::GetUserShare() [0x7f09954717cc]
        sync_api::SyncManager::SyncInternal::MaybeSetSyncTabsInNigoriNode()
[0x7f09954696ea]
        sync_api::SyncManager::SyncInternal::UpdateEnabledTypes()
[0x7f099546965d]
        sync_api::SyncManager::SyncInternal::SignIn() [0x7f09954690d6]
...

[Yaron, 2011-08-31 02:03:05]

On 2011/08/29 18:56:53, Yaron wrote:
> On 2011/08/29 18:41:54, Yaron wrote:
> > Fixed the deps issues and the nit
> > 
> >
http://codereview.chromium.org/7767013/diff/1/chrome/common/chrome_switches.cc
> > File chrome/common/chrome_switches.cc (right):
> > 
> >
>
http://codereview.chromium.org/7767013/diff/1/chrome/common/chrome_switches.c...
> > chrome/common/chrome_switches.cc:523: const char
> > kEnableSyncSessionsForOtherClients[]  =
> > "enable-sync-sessions-for-other-clients";
> > On 2011/08/27 06:08:52, Andrew T Wilson wrote:
> > > line >80 chars
> > 
> > Done.
> 
> Actually, this doesn't quite work as expected. Starting up a previously
> configured client hits a CHECK because SignIn hasn't completed before the
first
> call to UpdateEnabledTypes (stack below). Should I add a conditional in
> UpdateEnabledTypes to see that it's initialized and also call
UpdateEnabledTypes
> at the bottom of init? I was hoping there would be a single place where the
user
> has changed their preferred set of types and perform the modification there
but
> I don't see it. 
> 
> 
> [16651:16685:242997249288:FATAL:sync_manager.cc(313)] Check failed:
> initialized_.
> Backtrace:
>         base::debug::StackTrace::StackTrace() [0x7f099349a312]
>         logging::LogMessage::~LogMessage() [0x7f0993421886]
>         sync_api::SyncManager::SyncInternal::GetUserShare() [0x7f09954717cc]
>         sync_api::SyncManager::SyncInternal::MaybeSetSyncTabsInNigoriNode()
> [0x7f09954696ea]
>         sync_api::SyncManager::SyncInternal::UpdateEnabledTypes()
> [0x7f099546965d]
>         sync_api::SyncManager::SyncInternal::SignIn() [0x7f09954690d6]
> ...

Ok, I fixed the check by adding a guard in MaybeSetSyncTabsInNigoriNode. Drew,
PTAL. Note, there was a re-base between 1 and 2

[Andrew T Wilson (Slow), 2011-09-01 00:04:14]

LGTM

[commit-bot: I haz the power, 2011-09-02 03:56:18]

Change committed as 99317