Require a user gesture to display the PPAPI file chooser

Require a user gesture to show the file chooser.
BUG=73070
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126609

[bbudge, 2011-08-26 19:28:03]

Wondering if I'm on the right track here. Will this break Flash or PDF?

[brettw, 2011-08-26 19:33:51]

This will break plugins running in the ChromeIPC proxy since the input event
message can get sent asynchronously. By the time any requests that result from
that are processed in the renderer, user gesture processing will be complete.

We've discussed several approaches in the past for this, and this is a general
problem we need to solve. I suspect the correct answer is to send back input
event ACKs so we know if the plugin is currently processing something, and
additionally add some kind of timeout.

The timeout would protect against malicious plugins who try to delay sending an
input ACK (since the proxy will be running in their address space we can't rely
on it for security decisions), and also allow some slop if the plugin sends the
input event to a background thread and issues a request from there.

[bbudge, 2011-09-16 22:24:49]

cc'ing Polina.
This CL isn't ready for review, but I wanted to give you a chance to take a
look. I know this will cause Flash problems because it requires a user gesture.
So to land this, I should first define a PPB_FileChooser_Trusted interface and
get them to switch over to it.

[brettw, 2011-09-16 22:25:52]

Seems like an OK approach

[bbudge, 2011-09-16 22:26:00]

On 2011/09/16 22:24:49, bbudge1 wrote:
> cc'ing Polina.
> This CL isn't ready for review, but I wanted to give you a chance to take a
> look. I know this will cause Flash problems because it requires a user
gesture.
> So to land this, I should first define a PPB_FileChooser_Trusted interface and
> get them to switch over to it.

I am going to start looking for ways to test this. If anyone has suggestions,
they're welcome.

[bbudge, 2012-03-09 20:48:57]

trung, to verify this won't break Flash.

[bbudge, 2012-03-13 23:27:17]

Ping, this is ready for a look.

[brettw, 2012-03-13 23:50:17]

lgtm

[commit-bot: I haz the power, 2012-03-14 00:43:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bbudge@chromium.org/7764002/25002

[commit-bot: I haz the power, 2012-03-14 07:46:00]

Change committed as 126609