Require a user gesture to display the PPAPI file chooser

webkit/plugins/ppapi/ppapi_plugin_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/plugins/ppapi/ppapi_plugin_instance.h"
 
 #include "base/bind.h"
 #include "base/debug/trace_event.h"
 #include "base/logging.h"
 #include "base/memory/linked_ptr.h"
@@ skipping 1227 matching lines @@
   // container isn't ready yet, don't do anything more).
   if (fullscreen == IsFullscreenOrPending())
     return false;
 
   // Check whether we are trying to switch while the state is in transition.
   // The 2nd request gets dropped while messing up the internal state, so
   // disallow this.
   if (view_data_.is_fullscreen != desired_fullscreen_state_)
     return false;
 
-  if (fullscreen && !HasUserGesture())
+  if (fullscreen && !IsProcessingUserGesture())
     return false;
 
   VLOG(1) << "Setting fullscreen to " << (fullscreen ? "on" : "off");
   desired_fullscreen_state_ = fullscreen;
 
   if (fullscreen) {
     // Create the user gesture in case we're processing one that's pending.
     WebScopedUserGesture user_gesture;
     // WebKit does not resize the plugin to fill the screen in fullscreen mode,
     // so we will tweak plugin's attributes to support the expected behavior.
@@ skipping 402 matching lines @@
   // Don't actually verify that the object is in the set since during module
   // deletion we'll be in the process of freeing them.
   live_plugin_objects_.erase(plugin_object);
 }
 
 bool PluginInstance::IsFullPagePlugin() const {
   WebFrame* frame = container()->element().document().frame();
   return frame->view()->mainFrame()->document().isPluginDocument();
 }
 
+bool PluginInstance::IsProcessingUserGesture() {
+  PP_TimeTicks now =
+      ::ppapi::TimeTicksToPPTimeTicks(base::TimeTicks::Now());
+  // Give a lot of slack so tests won't be flaky. Well behaved plugins will
+  // close the user gesture.
+  const PP_TimeTicks kUserGestureDurationInSeconds = 10.0;
+  return (now - pending_user_gesture_ < kUserGestureDurationInSeconds);
+}
+
 void PluginInstance::OnLockMouseACK(bool succeeded) {
   if (!lock_mouse_callback_.func) {
     NOTREACHED();
     return;
   }
   PP_RunAndClearCompletionCallback(&lock_mouse_callback_,
                                    succeeded ? PP_OK : PP_ERROR_FAILED);
 }
 
 void PluginInstance::OnMouseLockLost() {
@@ skipping 28 matching lines @@
 
 void PluginInstance::ClosePendingUserGesture(PP_Instance instance,
                                              PP_TimeTicks timestamp) {
   // Close the pending user gesture if the plugin had a chance to respond.
   // Don't close the pending user gesture if the timestamps are equal since
   // there may be multiple input events with the same timestamp.
   if (timestamp > pending_user_gesture_)
     pending_user_gesture_ = 0.0;
 }
 
-bool PluginInstance::HasUserGesture() {
-  PP_TimeTicks now =
-      ::ppapi::TimeTicksToPPTimeTicks(base::TimeTicks::Now());
-  // Give a lot of slack so tests won't be flaky. Well behaved plugins will
-  // close the user gesture.
-  const PP_TimeTicks kUserGestureDurationInSeconds = 10.0;
-  return (now - pending_user_gesture_ < kUserGestureDurationInSeconds);
-}
-
 PPB_Instance_FunctionAPI* PluginInstance::AsPPB_Instance_FunctionAPI() {
   return this;
 }
 
 PP_Bool PluginInstance::BindGraphics(PP_Instance instance,
                                      PP_Resource device) {
   if (bound_graphics_.get()) {
     if (GetBoundGraphics2D()) {
       GetBoundGraphics2D()->BindToInstance(NULL);
     } else if (GetBoundGraphics3D()) {
@@ skipping 369 matching lines @@
   screen_size_for_fullscreen_ = gfx::Size();
   WebElement element = container_->element();
   element.setAttribute(WebString::fromUTF8(kWidth), width_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kHeight), height_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kBorder), border_before_fullscreen_);
   element.setAttribute(WebString::fromUTF8(kStyle), style_before_fullscreen_);
 }
 
 }  // namespace ppapi
 }  // namespace webkit