Load both language packs and the resource dlls in ChromeFrame and look for localized strings

Load both language packs and the resource dlls in ChromeFrame and look for localized strings
in the language pack and the other resources like dialogs in the dll. The latter part is done
automatically by ATL.

BUG=94362
TEST=No change in behavior. The resources should continue to load as before.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98502

[tony, 2011-08-26 21:36:29]

LGTM

http://codereview.chromium.org/7763006/diff/2004/chrome_frame/simple_resource...
File chrome_frame/simple_resource_loader.cc (right):

http://codereview.chromium.org/7763006/diff/2004/chrome_frame/simple_resource...
chrome_frame/simple_resource_loader.cc:108: &data_pack_, &locale_pack_path)) {
Nit: Maybe we should just return the language as a wstring rather than
locale_pack_path.

http://codereview.chromium.org/7763006/diff/2004/chrome_frame/simple_resource...
File chrome_frame/simple_resource_loader.h (right):

http://codereview.chromium.org/7763006/diff/2004/chrome_frame/simple_resource...
chrome_frame/simple_resource_loader.h:62: FilePath* file_path);
Nit: Maybe renamed file_path to pak_file_path?

http://codereview.chromium.org/7763006/diff/2004/chrome_frame/simple_resource...
chrome_frame/simple_resource_loader.h:73: ui::DataPack* data_pack_;
Nit: You could probably make this a scoped_ptr.  If not, you could forward
declare the type.

[ananta, 2011-08-26 21:50:17]

Thanks for the quick review.

http://codereview.chromium.org/7763006/diff/2004/chrome_frame/simple_resource...
File chrome_frame/simple_resource_loader.cc (right):

http://codereview.chromium.org/7763006/diff/2004/chrome_frame/simple_resource...
chrome_frame/simple_resource_loader.cc:108: &data_pack_, &locale_pack_path)) {
On 2011/08/26 21:36:30, tony wrote:
> Nit: Maybe we should just return the language as a wstring rather than
> locale_pack_path.

Done.

http://codereview.chromium.org/7763006/diff/2004/chrome_frame/simple_resource...
File chrome_frame/simple_resource_loader.h (right):

http://codereview.chromium.org/7763006/diff/2004/chrome_frame/simple_resource...
chrome_frame/simple_resource_loader.h:62: FilePath* file_path);
On 2011/08/26 21:36:30, tony wrote:
> Nit: Maybe renamed file_path to pak_file_path?

Replaced file_path with the language parameter as requested.

http://codereview.chromium.org/7763006/diff/2004/chrome_frame/simple_resource...
chrome_frame/simple_resource_loader.h:73: ui::DataPack* data_pack_;
On 2011/08/26 21:36:30, tony wrote:
> Nit: You could probably make this a scoped_ptr.  If not, you could forward
> declare the type.
Removed the include of the file here and replaced it with a forward declaration.