Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5527)

Unified Diff: chrome_frame/simple_resource_loader.h

Issue 7763006: Load both language packs and the resource dlls in ChromeFrame and look for localized strings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome_frame/simple_resource_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome_frame/simple_resource_loader.h
===================================================================
--- chrome_frame/simple_resource_loader.h (revision 98458)
+++ chrome_frame/simple_resource_loader.h (working copy)
@@ -18,6 +18,10 @@
#include "base/gtest_prod_util.h"
#include "base/memory/singleton.h"
+namespace ui {
+class DataPack;
+} // namespace ui
+
class SimpleResourceLoader {
public:
@@ -48,15 +52,18 @@
SimpleResourceLoader();
~SimpleResourceLoader();
- // Finds the most-preferred resource DLL for the laguages in |language_tags|
+ // Finds the most-preferred resource dll and language pack for the laguages
+ // in |language_tags|
// in |locales_path|.
//
// Returns true on success with a handle to the DLL that was loaded in
- // |dll_handle| and its path in |file_path|.
- static bool LoadLocaleDll(const std::vector<std::wstring>& language_tags,
- const FilePath& locales_path,
- HMODULE* dll_handle,
- FilePath* file_path);
+ // |dll_handle|, the data pack in |data_pack| and the locale language in
+ // the |language| parameter.
+ static bool LoadLocalePack(const std::vector<std::wstring>& language_tags,
+ const FilePath& locales_path,
+ HMODULE* dll_handle,
+ ui::DataPack** data_pack,
+ std::wstring* language);
// Returns the string resource identified by message_id from the currently
// loaded locale dll.
@@ -67,6 +74,8 @@
FRIEND_TEST_ALL_PREFIXES(SimpleResourceLoaderTest, LoadLocaleDll);
std::wstring language_;
+ ui::DataPack* data_pack_;
+
HINSTANCE locale_dll_handle_;
};
« no previous file with comments | « no previous file | chrome_frame/simple_resource_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698