Issue 7762014: This likely broke the nacl_integration test, so reverting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7762014: This likely broke the nacl_integration test, so reverting. (Closed)

Created:
9 years, 3 months ago by levin

Modified:
9 years, 3 months ago

Reviewers:
brettw, brettw at google

CC:
chromium-reviews, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

This likely broke the nacl_integration test, so reverting. Revert 98511 - Don't send DidChangeView to the plugin unless the parameters have actually changed. Apparently WebKit sends the update for every layout, even if nothing has changed. Review URL: http://codereview.chromium.org/7761005 TBR=brettw@google.com Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98531

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -21 lines)			Patch
	M	webkit/plugins/ppapi/ppapi_plugin_instance.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
	M	webkit/plugins/ppapi/ppapi_plugin_instance.cc	View		2 chunks	+11 lines, -16 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM