Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issue 7761005: Don't send DidChangeView to the plugin unless the parameters have actually changed. (Closed)

Created:
9 years, 4 months ago by brettw
Modified:
9 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Don't send DidChangeView to the plugin unless the parameters have actually changed. Apparently WebKit sends the update for every layout, even if nothing has changed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -11 lines) Patch
M webkit/plugins/ppapi/ppapi_plugin_instance.h View 1 chunk +5 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppapi_plugin_instance.cc View 2 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
brettw
9 years, 4 months ago (2011-08-26 20:19:36 UTC) #1
darin (slow to review)
9 years, 4 months ago (2011-08-26 21:24:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698