Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Side by Side Diff: webkit/plugins/ppapi/ppapi_plugin_instance.h

Issue 7761005: Don't send DidChangeView to the plugin unless the parameters have actually changed. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_ 5 #ifndef WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
6 #define WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_ 6 #define WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
7 7
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 343 matching lines...) Expand 10 before | Expand all | Expand 10 after
354 // NULL until we have been initialized. 354 // NULL until we have been initialized.
355 WebKit::WebPluginContainer* container_; 355 WebKit::WebPluginContainer* container_;
356 356
357 // Plugin URL. 357 // Plugin URL.
358 GURL plugin_url_; 358 GURL plugin_url_;
359 359
360 // Indicates whether this is a full frame instance, which means it represents 360 // Indicates whether this is a full frame instance, which means it represents
361 // an entire document rather than an embed tag. 361 // an entire document rather than an embed tag.
362 bool full_frame_; 362 bool full_frame_;
363 363
364 // Indicates if we've ever sent a didChangeView to the plugin. This ensure we
365 // always send an initial notification, even if the position and clip are the
366 // same as the default values.
367 bool sent_did_change_view_;
368
364 // Position in the viewport (which moves as the page is scrolled) of this 369 // Position in the viewport (which moves as the page is scrolled) of this
365 // plugin. This will be a 0-sized rectangle if the plugin has not yet been 370 // plugin. This will be a 0-sized rectangle if the plugin has not yet been
366 // laid out. 371 // laid out.
367 gfx::Rect position_; 372 gfx::Rect position_;
368 373
369 // Current clip rect. This will be empty if the plugin is not currently 374 // Current clip rect. This will be empty if the plugin is not currently
370 // visible. This is in the plugin's coordinate system, so fully visible will 375 // visible. This is in the plugin's coordinate system, so fully visible will
371 // be (0, 0, w, h) regardless of scroll position. 376 // be (0, 0, w, h) regardless of scroll position.
372 gfx::Rect clip_; 377 gfx::Rect clip_;
373 378
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
490 uint32_t input_event_mask_; 495 uint32_t input_event_mask_;
491 uint32_t filtered_input_event_mask_; 496 uint32_t filtered_input_event_mask_;
492 497
493 DISALLOW_COPY_AND_ASSIGN(PluginInstance); 498 DISALLOW_COPY_AND_ASSIGN(PluginInstance);
494 }; 499 };
495 500
496 } // namespace ppapi 501 } // namespace ppapi
497 } // namespace webkit 502 } // namespace webkit
498 503
499 #endif // WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_ 504 #endif // WEBKIT_PLUGINS_PPAPI_PPAPI_PLUGIN_INSTANCE_H_
OLDNEW
« no previous file with comments | « no previous file | webkit/plugins/ppapi/ppapi_plugin_instance.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698