Issue 7754020: Fix support when 2 properties are modified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7754020: Fix support when 2 properties are modified. (Closed)

Created:
9 years, 3 months ago by M-A Ruel

Modified:
9 years, 3 months ago

Reviewers:
Dirk Pranke, commit-bot: I haz the power

CC:
chromium-reviews, Dirk Pranke, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

Description

Fix support when 2 properties are modified. Add regression test. R=dpranke@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100209

Patch Set 1 #

Total comments: 3

Created: 9 years, 3 months ago

		Unified diffs	Side-by-side diffs	Stats (+21 lines, -7 lines)
	M	rietveld.py	View	1 chunk	+8 lines, -7 lines	2 comments
	M	tests/rietveld_test.py	View	1 chunk	+13 lines, -0 lines	1 comment

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

http://codereview.chromium.org/7754020/diff/1/rietveld.py File rietveld.py (left): http://codereview.chromium.org/7754020/diff/1/rietveld.py#oldcode197 rietveld.py:197: Can you explain what the bug was here and ...

9 years, 3 months ago (2011-09-08 18:35:33 UTC) #2

M-A Ruel

9 years, 3 months ago (2011-09-08 18:37:57 UTC) #3

Change committed as 100209

Expand Messages | Collapse Messages