Fix support when 2 properties are modified.

rietveld.py

Index: rietveld.py
diff --git a/rietveld.py b/rietveld.py
index e64a46d1c9decd04ecf2266cb1501667945530c4..9a70ee75eae074b09449f2d78092179764edeabf 100644
--- a/rietveld.py
+++ b/rietveld.py
@@ -187,14 +187,15 @@ class Rietveld(object):
     # \n
     # Added: svn:ignore\n
     #    + LF\n
-    while rietveld_svn_props:
-      spacer = rietveld_svn_props.pop(0)
-      if spacer or not rietveld_svn_props:
-        # svn diff always put a spacer between the unified diff and property
-        # diff
-        raise patch.UnsupportedPatchFormat(
-            filename, 'Failed to parse svn properties.')
 

[Dirk Pranke, 2011/09/08 18:35:36]

Can you explain what the bug was here and why this fixes it? I'm not following
the fix.

[M-A Ruel, 2011/09/08 18:37:58]

The new unit test checks exactly that; when there's multiple svn metadata, they
are not separated by multiple lines as I thought they were.

+    spacer = rietveld_svn_props.pop(0)
+    if spacer or not rietveld_svn_props:
+      # svn diff always put a spacer between the unified diff and property
+      # diff
+      raise patch.UnsupportedPatchFormat(
+          filename, 'Failed to parse svn properties.')
+
+    while rietveld_svn_props:
       # Something like 'Added: svn:eol-style'. Note the action is localized.
       # *sigh*.
       action = rietveld_svn_props.pop(0)