Implement identity hashes for proxies.

Implement identity hashes for proxies.

R=mstarzinger@chromium.org
BUG=v8:1543, v8:1565
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=9396

[Michael Starzinger, 2011-09-09 09:39:59]

LGTM (with comments addressed).

http://codereview.chromium.org/7754015/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/7754015/diff/1/src/heap.cc#newcode3524
src/heap.cc:3524: MaybeObject* maybe =
jsobj->GetHiddenProperties(JSObject::ALLOW_CREATION);
Can we move that into a separate method JSObject::SetIdentityHash() to keep the
identity hashing code together?

http://codereview.chromium.org/7754015/diff/1/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/7754015/diff/1/src/objects.h#newcode1434
src/objects.h:1434: enum CreationFlag { ALLOW_CREATION, OMIT_CREATION };
The use of this flag is ambiguous, it is used to indicate two different things.
Can we use two different flags for that purpose?
1) Allow creation of an object holding hidden properties
2) Allow generation of a permanent identity hash code

[rossberg, 2011-09-12 10:50:08]

http://codereview.chromium.org/7754015/diff/1/src/heap.cc
File src/heap.cc (right):

http://codereview.chromium.org/7754015/diff/1/src/heap.cc#newcode3524
src/heap.cc:3524: MaybeObject* maybe =
jsobj->GetHiddenProperties(JSObject::ALLOW_CREATION);
On 2011/09/09 09:40:00, Michael Starzinger wrote:
> Can we move that into a separate method JSObject::SetIdentityHash() to keep
the
> identity hashing code together?

Done.

http://codereview.chromium.org/7754015/diff/1/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/7754015/diff/1/src/objects.h#newcode1434
src/objects.h:1434: enum CreationFlag { ALLOW_CREATION, OMIT_CREATION };
On 2011/09/09 09:40:00, Michael Starzinger wrote:
> The use of this flag is ambiguous, it is used to indicate two different
things.
> Can we use two different flags for that purpose?
> 1) Allow creation of an object holding hidden properties
> 2) Allow generation of a permanent identity hash code

As discussed offline, moved the enum type out of JSReceiver to mirror its more
universal meaning.