Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Side by Side Diff: src/objects-debug.cc

Issue 7754015: Implement identity hashes for proxies. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed Michael's comments. Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 492 matching lines...) Expand 10 before | Expand all | Expand 10 after
503 } 503 }
504 default: 504 default:
505 ASSERT_EQ(JSRegExp::NOT_COMPILED, TypeTag()); 505 ASSERT_EQ(JSRegExp::NOT_COMPILED, TypeTag());
506 ASSERT(data()->IsUndefined()); 506 ASSERT(data()->IsUndefined());
507 break; 507 break;
508 } 508 }
509 } 509 }
510 510
511 511
512 void JSProxy::JSProxyVerify() { 512 void JSProxy::JSProxyVerify() {
513 ASSERT(IsJSProxy()); 513 CHECK(IsJSProxy());
514 VerifyPointer(handler()); 514 VerifyPointer(handler());
515 ASSERT(hash()->IsSmi() || hash()->IsUndefined());
515 } 516 }
516 517
517 518
518 void JSFunctionProxy::JSFunctionProxyVerify() { 519 void JSFunctionProxy::JSFunctionProxyVerify() {
519 ASSERT(IsJSFunctionProxy()); 520 CHECK(IsJSFunctionProxy());
520 JSProxyVerify(); 521 JSProxyVerify();
521 VerifyPointer(call_trap()); 522 VerifyPointer(call_trap());
522 VerifyPointer(construct_trap()); 523 VerifyPointer(construct_trap());
523 } 524 }
524 525
525 526
526 void Foreign::ForeignVerify() { 527 void Foreign::ForeignVerify() {
527 ASSERT(IsForeign()); 528 ASSERT(IsForeign());
528 } 529 }
529 530
(...skipping 253 matching lines...) Expand 10 before | Expand all | Expand 10 after
783 ASSERT(e->IsUndefined()); 784 ASSERT(e->IsUndefined());
784 } 785 }
785 } 786 }
786 } 787 }
787 } 788 }
788 789
789 790
790 #endif // DEBUG 791 #endif // DEBUG
791 792
792 } } // namespace v8::internal 793 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | src/objects-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698