Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 7754001: Revert 98230 - CL removing inheritance of SkDevice from PlatformDevice. (Closed)

Created:
9 years, 4 months ago by Jeff Timanus
Modified:
9 years, 4 months ago
Reviewers:
Jeff Timanus
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 98230 - CL removing inheritance of SkDevice from PlatformDevice. PlatformDevice is now a base interface, which is implemented by the various flavours of BitmapPlatformDevice, and VectorPlatformDevice. The BitmapPlatformDevice and VectorPlatformDevice classes now inherit directly from SkDevice, or SkPDFDevice, as appropriate. PlatformDevice helper functions access the PlatformDevice interface attached to a SkDevice via meta-data on the SkDevice. BUG=none TEST=none Review URL: http://codereview.chromium.org/7633040 TBR=twiz@chromium.org,jbates@chromium.org, dpolukhin@chromium.org, sanjeevr@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98233

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -234 lines) Patch
M printing/pdf_metafile_skia.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M skia/ext/bitmap_platform_device_linux.h View 3 chunks +9 lines, -12 lines 0 comments Download
M skia/ext/bitmap_platform_device_linux.cc View 2 chunks +1 line, -8 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.h View 4 chunks +7 lines, -8 lines 0 comments Download
M skia/ext/bitmap_platform_device_mac.cc View 1 chunk +1 line, -2 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.h View 5 chunks +18 lines, -14 lines 0 comments Download
M skia/ext/bitmap_platform_device_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M skia/ext/platform_device.h View 3 chunks +17 lines, -113 lines 0 comments Download
M skia/ext/platform_device.cc View 1 chunk +1 line, -8 lines 0 comments Download
A + skia/ext/platform_device_linux.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M skia/ext/platform_device_linux.cc View 1 chunk +13 lines, -2 lines 0 comments Download
A + skia/ext/platform_device_mac.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M skia/ext/platform_device_mac.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A + skia/ext/platform_device_win.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M skia/ext/platform_device_win.cc View 4 chunks +5 lines, -7 lines 0 comments Download
M skia/ext/vector_platform_device_cairo_linux.h View 2 chunks +6 lines, -9 lines 0 comments Download
M skia/ext/vector_platform_device_cairo_linux.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.h View 2 chunks +6 lines, -4 lines 0 comments Download
M skia/ext/vector_platform_device_emf_win.cc View 5 chunks +9 lines, -6 lines 0 comments Download
M skia/ext/vector_platform_device_skia.h View 2 chunks +51 lines, -7 lines 0 comments Download
M skia/ext/vector_platform_device_skia.cc View 5 chunks +149 lines, -19 lines 0 comments Download
M skia/skia.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Jeff Timanus
9 years, 4 months ago (2011-08-25 15:30:17 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698