Add 'arch' field to Mac files list for consistency on all platforms.

Add 'arch' field to Mac files list for consistency on all platforms.

TEST=Fix Mac official build staging step.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98437

[kerz_chromium, 2011-08-26 17:20:20]

LGTM

On Fri, Aug 26, 2011 at 10:13 AM, <mmoss@chromium.org> wrote:

> Reviewers: kerz_chromium,
>
> Description:
> Add 'arch' field to Mac files list for consistency on all platforms.
>
> TEST=Fix Mac official build staging step.
>
>
> Please review this at
http://codereview.chromium.**org/7753039/<http://codereview.chromium.org/7753...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/tools/build/mac/FILES.**cfg
>
>
> Index: chrome/tools/build/mac/FILES.**cfg
> diff --git a/chrome/tools/build/mac/**FILES.cfg b/chrome/tools/build/mac/*
> *FILES.cfg
> index 8a09559967f4997eb81537699f2400**50fa09a012..**
> 535a09662aa6c47d7bb88f3688c01b**7cdf261c82 100644
> --- a/chrome/tools/build/mac/**FILES.cfg
> +++ b/chrome/tools/build/mac/**FILES.cfg
> @@ -9,27 +9,36 @@
>  # processed by the stage/archive scripts. The known tags are:
>  #
>  # filename: Name of the file in the build output directory.
> +# arch:     List of CPU architectures for which this file should be
> processed
> +#           (values are based on the strings returned by python's
> +#           platform.architecture() function).
> +#           Note: Mac doesn't really care about 'arch' (like Linux does)
> +#           because binaries are packaged to support multiple
> architectures,
> +#           but we still tag the files to allow consistent handling in the
> +#           buildbot scripts. Tagging them all as both 32bit and 64bit is
> the
> +#           safest bet.
>  # buildtype: List of build types for which this file should be processed.
> -#
> -# Note, Mac doesn't tag FILES with 'arch' (like Linux does) because
> binaries
> -# are packaged to support multiple architectures.
>
>  FILES = [
>   {
>     'filename': 'Chromium.app',
> +    'arch': ['32bit', '64bit'],
>     'buildtype': ['dev'],
>   },
>   {
>     'filename': 'Google Chrome.app',
> +    'arch': ['32bit', '64bit'],
>     'buildtype': ['official'],
>   },
>   {
>     'filename': 'Google Chrome Packaging',
> +    'arch': ['32bit', '64bit'],
>     'buildtype': ['official'],
>   },
>   # Remoting Host plugin files:
>   {
>     'filename': 'remoting_host_plugin.plugin',
> +    'arch': ['32bit', '64bit'],
>     'buildtype': ['dev', 'official'],
>   },
>  ]
>
>
>