Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Unified Diff: chrome/tools/build/mac/FILES.cfg

Issue 7753039: Add 'arch' field to Mac files list for consistency on all platforms. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/tools/build/mac/FILES.cfg
diff --git a/chrome/tools/build/mac/FILES.cfg b/chrome/tools/build/mac/FILES.cfg
index 8a09559967f4997eb81537699f240050fa09a012..535a09662aa6c47d7bb88f3688c01b7cdf261c82 100644
--- a/chrome/tools/build/mac/FILES.cfg
+++ b/chrome/tools/build/mac/FILES.cfg
@@ -9,27 +9,36 @@
# processed by the stage/archive scripts. The known tags are:
#
# filename: Name of the file in the build output directory.
+# arch: List of CPU architectures for which this file should be processed
+# (values are based on the strings returned by python's
+# platform.architecture() function).
+# Note: Mac doesn't really care about 'arch' (like Linux does)
+# because binaries are packaged to support multiple architectures,
+# but we still tag the files to allow consistent handling in the
+# buildbot scripts. Tagging them all as both 32bit and 64bit is the
+# safest bet.
# buildtype: List of build types for which this file should be processed.
-#
-# Note, Mac doesn't tag FILES with 'arch' (like Linux does) because binaries
-# are packaged to support multiple architectures.
FILES = [
{
'filename': 'Chromium.app',
+ 'arch': ['32bit', '64bit'],
'buildtype': ['dev'],
},
{
'filename': 'Google Chrome.app',
+ 'arch': ['32bit', '64bit'],
'buildtype': ['official'],
},
{
'filename': 'Google Chrome Packaging',
+ 'arch': ['32bit', '64bit'],
'buildtype': ['official'],
},
# Remoting Host plugin files:
{
'filename': 'remoting_host_plugin.plugin',
+ 'arch': ['32bit', '64bit'],
'buildtype': ['dev', 'official'],
},
]
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698