Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(876)

Issue 7753037: Revert 98424 - Revert 98398 - Disabling the ReadyPromptContentTest and the (Closed)

Created:
9 years, 4 months ago by battre
Modified:
9 years, 4 months ago
Reviewers:
battre
CC:
chromium-reviews, amit, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 98424 - Revert 98398 - Disabling the ReadyPromptContentTest and the TopLevelPostReissueFromChromeFramePage tests as these tests rely on resource dlls being present in the locales folder. After revision 98103 it looks like chrome uses resource packs internally. We need to fix ChromeFrame to not use resource dlls and use the packs instead. BUG=94362 Review URL: http://codereview.chromium.org/7740045 TBR=ananta@chromium.org Review URL: http://codereview.chromium.org/7745050 TBR=battre@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome_frame/test/navigation_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome_frame/test/ready_mode_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
battre
9 years, 4 months ago (2011-08-26 16:36:13 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698