Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(455)

Issue 7740045: Disabling the ReadyPromptContentTest and the TopLevelPostReissueFromChromeFramePage (Closed)

Created:
9 years, 4 months ago by ananta
Modified:
9 years, 4 months ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews, amit, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disabling the ReadyPromptContentTest and the TopLevelPostReissueFromChromeFramePage tests as these tests rely on resource dlls being present in the locales folder. After revision 98103 it looks like chrome uses resource packs internally. We need to fix ChromeFrame to not use resource dlls and use the packs instead. BUG=94362 TBR=grt Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98398

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome_frame/test/navigation_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome_frame/test/ready_mode_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
9 years, 4 months ago (2011-08-26 07:28:43 UTC) #1
grt (UTC plus 2)
9 years, 4 months ago (2011-08-26 14:59:12 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698