Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1144)

Issue 7753035: Allow each WGC3D subclass to determine the correct GrGLInterface for its GrContext. (Closed)

Created:
9 years, 4 months ago by bsalomon
Modified:
9 years, 3 months ago
CC:
Alexei Svitkine (slow), chromium-reviews, joi+watch-content_chromium.org, pam+watch_chromium.org, jam, darin-cc_chromium.org, apatrick_chromium
Visibility:
Public.

Description

Allow each WGC3D subclass to determine the correct GrGLInterface for its GrContext. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -13 lines) Patch
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/gpu/webgraphicscontext3d_command_buffer_impl.cc View 2 chunks +6 lines, -1 line 0 comments Download
M ui/gfx/gl/gl_bindings_skia_in_process.h View 1 chunk +3 lines, -1 line 0 comments Download
M ui/gfx/gl/gl_bindings_skia_in_process.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webkit/glue/gl_bindings_skia_cmd_buffer.h View 1 chunk +3 lines, -1 line 0 comments Download
M webkit/glue/gl_bindings_skia_cmd_buffer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_command_buffer_impl.cc View 2 chunks +7 lines, -1 line 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webkit/gpu/webgraphicscontext3d_in_process_impl.cc View 2 chunks +6 lines, -1 line 0 comments Download
M webkit/tools/test_shell/test_shell_webkit_init.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
bsalomon
Currently we set a global variable, the "default" gl interface ptr, when a WGC3D is ...
9 years, 4 months ago (2011-08-26 15:34:36 UTC) #1
Ken Russell (switch to Gerrit)
LGTM. This is a nice virtualization.
9 years, 4 months ago (2011-08-27 01:20:14 UTC) #2
tony
9 years, 3 months ago (2011-08-28 14:27:57 UTC) #3
webkit/glue and webkit/tools/test_shell LGTM.

Powered by Google App Engine
This is Rietveld 408576698