Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 7753013: content: Make ifdefs match with where this is used (Closed)

Created:
9 years, 4 months ago by Elliot Glaysher
Modified:
9 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

content: Move touchui's RenderWidgetHostView::GetDefaultScreenInfo() into a place to make things link (Fixes trybot linkage on linux_touch) BUG=90443 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98389

Patch Set 1 #

Patch Set 2 : Possible fix #

Total comments: 1

Patch Set 3 : mac header fix #

Patch Set 4 : Factor out common code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -54 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_views_gtk.cc View 1 2 3 4 chunks +3 lines, -35 lines 0 comments Download
A content/browser/renderer_host/gtk_window_utils.h View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A content/browser/renderer_host/gtk_window_utils.cc View 1 2 3 1 chunk +32 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view.cc View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_gtk.cc View 1 2 3 4 chunks +3 lines, -19 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Elliot Glaysher
This ifdef says mac, but in the header it says posix and in the RWH ...
9 years, 4 months ago (2011-08-25 21:36:31 UTC) #1
jam
this was moved over from render_widget_host_view_mac.mm in http://codereview.chromium.org/7746008 to fix a link error on mac.
9 years, 4 months ago (2011-08-25 21:42:27 UTC) #2
Elliot Glaysher
On 2011/08/25 21:42:27, John Abd-El-Malek wrote: > this was moved over from render_widget_host_view_mac.mm in > ...
9 years, 4 months ago (2011-08-25 21:59:25 UTC) #3
jam
http://codereview.chromium.org/7753013/diff/4001/content/browser/renderer_host/render_widget_host_view.cc File content/browser/renderer_host/render_widget_host_view.cc (right): http://codereview.chromium.org/7753013/diff/4001/content/browser/renderer_host/render_widget_host_view.cc#newcode25 content/browser/renderer_host/render_widget_host_view.cc:25: // TODO(erg): move this to render_widget_host_view_views_gtk.cc when if it ...
9 years, 4 months ago (2011-08-25 23:13:54 UTC) #4
jam
great cleanup, thanks lgtm
9 years, 4 months ago (2011-08-26 00:04:51 UTC) #5
commit-bot: I haz the power
9 years, 4 months ago (2011-08-26 03:00:34 UTC) #6
Change committed as 98389

Powered by Google App Engine
This is Rietveld 408576698