Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Unified Diff: chrome/browser/renderer_host/render_widget_host_view_views_gtk.cc

Issue 7753013: content: Make ifdefs match with where this is used (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Factor out common code Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/renderer_host/gtk_window_utils.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/renderer_host/render_widget_host_view_views_gtk.cc
diff --git a/chrome/browser/renderer_host/render_widget_host_view_views_gtk.cc b/chrome/browser/renderer_host/render_widget_host_view_views_gtk.cc
index a8f721be3997b76bb4e4039ed2a3c93e4aeb0e81..e8437a730fd86b1022d01093d7689d9ccb9243c9 100644
--- a/chrome/browser/renderer_host/render_widget_host_view_views_gtk.cc
+++ b/chrome/browser/renderer_host/render_widget_host_view_views_gtk.cc
@@ -7,6 +7,7 @@
#include <gdk/gdkx.h>
#include <gtk/gtk.h>
+#include "content/browser/renderer_host/gtk_window_utils.h"
#include "ui/base/keycodes/keyboard_code_conversion_gtk.h"
#include "ui/base/x/x11_util.h"
#include "ui/gfx/gtk_native_view_id_manager.h"
@@ -14,30 +15,6 @@
#include "views/widget/native_widget_gtk.h"
#include "third_party/WebKit/Source/WebKit/chromium/public/WebScreenInfo.h"
-#include "third_party/WebKit/Source/WebKit/chromium/public/x11/WebScreenInfoFactory.h"
-
-namespace {
-
-// TODO(oshima): This is a copy from RenderWidgetHostViewGtk. Replace this
-// with gdk-less implementation.
-void GetScreenInfoFromNativeWindow(
- GdkWindow* gdk_window, WebKit::WebScreenInfo* results) {
- GdkScreen* screen = gdk_drawable_get_screen(gdk_window);
- *results = WebKit::WebScreenInfoFactory::screenInfo(
- gdk_x11_drawable_get_xdisplay(gdk_window),
- gdk_x11_screen_get_screen_number(screen));
-
- // TODO(tony): We should move this code into WebScreenInfoFactory.
- int monitor_number = gdk_screen_get_monitor_at_window(screen, gdk_window);
- GdkRectangle monitor_rect;
- gdk_screen_get_monitor_geometry(screen, monitor_number, &monitor_rect);
- results->rect = WebKit::WebRect(monitor_rect.x, monitor_rect.y,
- monitor_rect.width, monitor_rect.height);
- // TODO(tony): Should we query _NET_WORKAREA to get the workarea?
- results->availableRect = results->rect;
-}
-
-} // namespace
void RenderWidgetHostViewViews::UpdateCursor(const WebCursor& cursor) {
// Optimize the common case, where the cursor hasn't changed.
@@ -65,7 +42,8 @@ void RenderWidgetHostViewViews::DestroyPluginContainer(
void RenderWidgetHostViewViews::GetScreenInfo(WebKit::WebScreenInfo* results) {
views::Widget* widget = GetWidget() ? GetWidget()->GetTopLevelWidget() : NULL;
if (widget)
- GetScreenInfoFromNativeWindow(widget->GetNativeView()->window, results);
+ content::GetScreenInfoFromNativeWindow(widget->GetNativeView()->window,
+ results);
}
gfx::Rect RenderWidgetHostViewViews::GetRootWindowBounds() {
@@ -114,13 +92,3 @@ void RenderWidgetHostViewViews::ShowCurrentCursor() {
native_cursor_ = current_cursor_.GetNativeCursor();
}
-
-#if defined(TOUCH_UI)
-// static
-void RenderWidgetHostView::GetDefaultScreenInfo(
- WebKit::WebScreenInfo* results) {
- GdkWindow* gdk_window =
- gdk_display_get_default_group(gdk_display_get_default());
- GetScreenInfoFromNativeWindow(gdk_window, results);
-}
-#endif
« no previous file with comments | « no previous file | content/browser/renderer_host/gtk_window_utils.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698