Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 7753001: Fixed bool <-> Executability confusion and improved typing a bit. (Closed)

Created:
9 years, 4 months ago by Sven Panne
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fixed bool <-> Executability confusion and improved typing a bit. Passing a value of type Executability to a function expecting a bool worked only by accident (because of the order of values in the enum). But using boolean parameters is often a bad idea, anyway, so we use Executability directly. Just another example why implicit type conversions in C++ are a bad idea... :-P Committed: http://code.google.com/p/v8/source/detail?r=9013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M src/spaces.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/spaces.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M src/spaces-inl.h View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
9 years, 4 months ago (2011-08-25 09:55:29 UTC) #1
Erik Corry
Nice catch. Agree with the C++ comment. This is why I always have the negative ...
9 years, 4 months ago (2011-08-25 10:06:15 UTC) #2
Erik Corry
9 years, 4 months ago (2011-08-25 10:06:24 UTC) #3
Oh, and LGTM

Powered by Google App Engine
This is Rietveld 408576698