Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Side by Side Diff: src/spaces-inl.h

Issue 7753001: Fixed bool <-> Executability confusion and improved typing a bit. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/spaces.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2010 the V8 project authors. All rights reserved. 1 // Copyright 2006-2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 276 matching lines...) Expand 10 before | Expand all | Expand 10 after
287 287
288 bool Page::IsLargeObjectPage() { 288 bool Page::IsLargeObjectPage() {
289 return !GetPageFlag(IS_NORMAL_PAGE); 289 return !GetPageFlag(IS_NORMAL_PAGE);
290 } 290 }
291 291
292 292
293 void Page::SetIsLargeObjectPage(bool is_large_object_page) { 293 void Page::SetIsLargeObjectPage(bool is_large_object_page) {
294 SetPageFlag(IS_NORMAL_PAGE, !is_large_object_page); 294 SetPageFlag(IS_NORMAL_PAGE, !is_large_object_page);
295 } 295 }
296 296
297 bool Page::IsPageExecutable() { 297 Executability Page::PageExecutability() {
298 return GetPageFlag(IS_EXECUTABLE); 298 return GetPageFlag(IS_EXECUTABLE) ? EXECUTABLE : NOT_EXECUTABLE;
299 } 299 }
300 300
301 301
302 void Page::SetIsPageExecutable(bool is_page_executable) { 302 void Page::SetPageExecutability(Executability executable) {
303 SetPageFlag(IS_EXECUTABLE, is_page_executable); 303 SetPageFlag(IS_EXECUTABLE, executable == EXECUTABLE);
304 } 304 }
305 305
306 306
307 // ----------------------------------------------------------------------------- 307 // -----------------------------------------------------------------------------
308 // MemoryAllocator 308 // MemoryAllocator
309 309
310 void MemoryAllocator::ChunkInfo::init(Address a, size_t s, PagedSpace* o) { 310 void MemoryAllocator::ChunkInfo::init(Address a, size_t s, PagedSpace* o) {
311 address_ = a; 311 address_ = a;
312 size_ = s; 312 size_ = s;
313 owner_ = o; 313 owner_ = o;
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
491 491
492 bool FreeListNode::IsFreeListNode(HeapObject* object) { 492 bool FreeListNode::IsFreeListNode(HeapObject* object) {
493 return object->map() == HEAP->raw_unchecked_byte_array_map() 493 return object->map() == HEAP->raw_unchecked_byte_array_map()
494 || object->map() == HEAP->raw_unchecked_one_pointer_filler_map() 494 || object->map() == HEAP->raw_unchecked_one_pointer_filler_map()
495 || object->map() == HEAP->raw_unchecked_two_pointer_filler_map(); 495 || object->map() == HEAP->raw_unchecked_two_pointer_filler_map();
496 } 496 }
497 497
498 } } // namespace v8::internal 498 } } // namespace v8::internal
499 499
500 #endif // V8_SPACES_INL_H_ 500 #endif // V8_SPACES_INL_H_
OLDNEW
« no previous file with comments | « src/spaces.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698