Issue 7748035: PNaClTargetInfo: add __ELF__, _REENTRANT and _GNU_SOURCE defines and update the test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7748035: PNaClTargetInfo: add ELF, _REENTRANT and _GNU_SOURCE defines and update the test. (Closed)

Created:
9 years, 4 months ago by krasin

Modified:
9 years, 3 months ago

Reviewers:
jvoung - send to chromium...

CC:
native-client-reviews_googlegroups.com

Base URL:
https://llvm.org/svn/llvm-project/cfe/trunk/

Visibility:
Public.

Description

Add missing defines to PNaCl target in Clang which made clang++ to complain on #include <stdio.h>: In file included from /usr/local/google/home/krasin/llvm-commit/tools/clang/test/Driver/le32-unknown-nacl.cpp:112: /usr/include/stdio.h:432:26: error: expected ';' after top level declarator __isoc99_sscanf) __THROW; ^ ; /usr/include/stdio.h:487:27: error: expected ';' after top level declarator __isoc99_vsscanf) ^ ; 2 errors generated.

Patch Set 1 #

Patch Set 2 : include <stdio.h> in the test #

Total comments: 1

Created: 9 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -0 lines)			Patch
	M	lib/Basic/Targets.cpp	View		1 chunk	+7 lines, -0 lines	0 comments	Download
	M	test/Driver/le32-unknown-nacl.cpp	View	1	2 chunks	+21 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jvoung - send to chromium...

9 years, 4 months ago (2011-08-26 00:06:05 UTC) #2

http://codereview.chromium.org/7748035/diff/2001/test/Driver/le32-unknown-nac...
File test/Driver/le32-unknown-nacl.cpp (right):

http://codereview.chromium.org/7748035/diff/2001/test/Driver/le32-unknown-nac...
test/Driver/le32-unknown-nacl.cpp:43: // CHECK: _GNU_SOURCEdefined
Does this set Opts.CPlusPlus? I guess so.

To test _REENTRANT, can you run clang with the "-pthread" option?